Merge pull request #293 for release #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Power-Maverick <[email protected]>
Co-authored-by: Power-Maverick <[email protected]>
Co-authored-by: Power-Maverick <[email protected]>
Co-authored-by: Power-Maverick <[email protected]>
…-and-server Fix: Reverse web resource compare order - Server (left) vs Local (right)
…ion-error Fix: Display error messages when web resource upload fails due to connection timeout or expired token
- Add tokenExpiresAt field to IConnection interface - Update token creation points to store expiration timestamp - Add isCurrentConnectionTokenExpired helper method - Update connection tree item to show expired icon (red/orange) - Add periodic timer to check token expiration - Show warning notification when token expires - Update status bar to show warning icon and "Token Expired" text Co-authored-by: Power-Maverick <[email protected]>
- Add command to update status bar from external callers - Add getCurrentWorkspaceConnection helper method - Update token expiration checker to also update status bar Co-authored-by: Power-Maverick <[email protected]>
- Remove dataverse-expired.svg files - Update code to use dataverse-off.svg for expired connections - dataverse-off.svg already has appropriate red/pink color scheme Co-authored-by: Power-Maverick <[email protected]>
…visibility Co-authored-by: Power-Maverick <[email protected]>
- Get current workspace connection before showing notification - Create DataverseConnectionTreeItem object with connection details - Pass connItem to connectDataverse command to fix execution error - Add null check to ensure connection exists before reconnecting Co-authored-by: Power-Maverick <[email protected]>
- Update populateConnections to copy tokenExpiresAt from workspace connection - This ensures the connection tree can properly check token expiration - Connection tree will now refresh and show expired icon when token expires Co-authored-by: Power-Maverick <[email protected]>
- Create dataverse-expired.svg with orange/amber color scheme - Use orange (#FFA500, #FF8C00) instead of red or green - Update connection tree to use new expired icon - Provides distinct visual indicator for connected but expired state Co-authored-by: Power-Maverick <[email protected]>
…meout-indicator Fix: Add visual indicators and notifications for expired connection tokens
…ptions immediately Co-authored-by: Power-Maverick <[email protected]>
…meout-indicator Fix: Update command registration and improve status bar text for conn…
…n-bug Fix: Context menu options not appearing after linking/initialization until VS Code restart
Added the GNU General Public License version 3 to the project.
Co-authored-by: Power-Maverick <[email protected]>
Co-authored-by: Power-Maverick <[email protected]>
…-release docs: Update README for v2.2.5 release with new features and bug fixes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements token expiration tracking and management for Dataverse connections in v2.2.6. The changes add automatic detection of expired authentication tokens, visual indicators for expired connections, and periodic monitoring to notify users when tokens need renewal.
Key changes include:
- Added token expiration timestamp tracking to connection interfaces
- Implemented automatic token expiration monitoring with user notifications
- Enhanced connection tree view to show expired token states with visual indicators
Reviewed Changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/Interfaces.ts | Added tokenExpiresAt field to IConnection interface for tracking token expiration |
| src/utils/ErrorMessages.ts | Added error message for web resource upload failures |
| src/trees/dataverseConnectionDataProvider.ts | Enhanced tree provider to handle and display expired token states |
| src/helpers/webResourceHelper.ts | Added error handling and context updates for web resource operations |
| src/helpers/templateHelper.ts | Added VS Code context updates for project type detection |
| src/helpers/requestHelper.ts | Enhanced error propagation in request methods |
| src/helpers/dataverseHelper.ts | Implemented token expiration tracking and validation methods |
| src/extension.ts | Added periodic token expiration monitoring and user notifications |
| src/commands/registerCommands.ts | Fixed command order and enhanced status bar with expiration indicators |
| README.md | Updated documentation with recent feature additions and improvements |
| LICENSE | Changed from MIT to GPL v3 license |
| .eslintrc.json | Removed semicolon rule from ESLint configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
…averse DevTools extension
Restored recent updates section with details about version 2.2.6 improvements, including file comparison, token monitoring, and stability fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.2.6